Repository navigation
release: v1.3.0 - #65
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.3.0. Minor bump because #63 adds a public exception type.
What's Changed
FinanceNetAccessDeniedException(derives fromFinanceNetException) for a request Alpha Vantage refuses for the account: a premium-only endpoint called with a free key, or an invalid or missing API key. It is thrown by all four Alpha Vantage methods, is excluded from the retry policy and is not wrapped, soInnerExceptionis null. Such a call now fails in well under a second instead of running through the whole back-off budget, which took several minutes. Thanks to @werwolfby for the report and the fix.FinanceNetException.GetOverviewAsyncpreviously read the notice as an empty overview and reportedFinanceNetNoDataExceptionwithout retrying.GetRecordsAsyncstill callsTIME_SERIES_DAILY_ADJUSTED, which Alpha Vantage serves to premium keys only. With a free key it now fails immediately withFinanceNetAccessDeniedException.Behaviour Changes
catch (FinanceNetException)blocks keep working. Code that matches on the exact exception type or on the message of a refused Alpha Vantage request needs updating, because the type is nowFinanceNetAccessDeniedExceptionand the message changed.🤖 Generated with Claude Code