Repository navigation
Keep an Alpha Vantage rate-limit notice retryable - #64
Merged
Merged
Conversation
Assert.ThrowsAsync matches the exact type, so the negative cases turned red once #63 made a refused request throw FinanceNetAccessDeniedException. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The notice advertises "premium endpoints", so the "premium endpoint" marker classified a temporary rate limit as a permanent refusal. The marker now matches the full sentence. The notice also lacks the old "higher API call volume" wording, so GetOverviewAsync deserialized it to an empty object and reported no data without retrying. "rate limit" is now recognised as a retryable limit in all four methods. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Follow-up to #63.
Changes
tests/IntegrationTests/AlphaVantageTests.csuseAssert.CatchAsyncinstead ofAssert.ThrowsAsync.ThrowsAsyncmatches the exact type, so they fail since a refused request throws the derivedFinanceNetAccessDeniedException. CI runs unit tests only and did not show this.GetOverviewAsyncdeserialized the notice to an empty object and threwFinanceNetNoDataExceptionafter a single request.InnerExceptionis null, and the XML summary on the privateThrowIfRejectedbecame a one-line comment.No public API change,
Constantsis internal.Verification
dotnet build Finance.NET.slnx --configuration Release: 0 warnings, 0 errorsdotnet test tests/Tests.csproj --configuration Release --filter "TestCategory=Unit": 207 passed, 0 failedRateLimit_IsStillRetriedcases fail withFinanceNetAccessDeniedException.🤖 Generated with Claude Code