Repository navigation
Clean the release profile when staging release DLLs - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Release job still failed at "Stage the runtime DLLs".
cargo clean -p sherpa-onnx-syswithout--releaseonly cleans the dev profile, so in the release job it removed 0 files, the crate stayed fresh, its build script never reran, and nothing was downloaded. The clean now gets the same profile flag as the build.Verification
Reproduced locally for the release profile: emptied the cached DLLs, ran the script. It removed 24 files, the build script re-downloaded the archive, and all four DLLs were staged. CI covers only the debug path; the release path runs on the merge to
main.🤖 Generated with Claude Code