Repository navigation
Fix the two CI failures: svelte-kit sync and the runtime DLLs - #12
Merged
Merged
Conversation
… build script leaves them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI failures that surfaced once the lint step stopped hiding them:
npm cino longer ransvelte-kit sync(thepreparescript was dropped frompackage.json), so.svelte-kit/tsconfig.jsonwas missing and eslint reported every import as an unresolvederrortype. The script is back.scripts/stage-runtime.ps1looked for the sherpa-onnx DLLs intarget/<profile>, where the build script only copies them when it actually runs. With a warm Rust cache it does not. The script now reads them fromtarget/sherpa-onnx-prebuilt, which persists, and rebuilds the crate once if that is empty. The same failure made the Release workflow fail on the merge of Format the data model doc #11, so no release was published.Verification
Locally, with
.svelte-kitregenerated from scratch:npm run lintpasses, and the stage script copies all four DLLs intosrc-tauri/runtime. The cold-cache fallback in the script has not been exercised.🤖 Generated with Claude Code