Skip to content

fix: handle existing releases when creating with artifacts #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thoroc merged 2 commits into from
Feb 7, 2026
Merged

fix: handle existing releases when creating with artifacts #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f32e621
fix: add shell: bash to version extraction steps
thoroc Feb 7, 2026
80549af
fix: delete existing release before creating with artifacts
thoroc Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ jobs:

- name: Extract version from Cargo.toml
id: get_version
shell: bash
run: |
VERSION=$(grep -E '^version\s*=' Cargo.toml | head -n1 | sed 's/.*"\(.*\)".*/\1/')
echo "version=${VERSION}" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -170,6 +171,7 @@ jobs:

- name: Extract version from Cargo.toml
id: get_version
shell: bash
run: |
VERSION=$(grep -E '^version\s*=' Cargo.toml | head -n1 | sed 's/.*"\(.*\)".*/\1/')
echo "version=${VERSION}" >> $GITHUB_OUTPUT
Expand All @@ -181,6 +183,14 @@ jobs:
run: |
cd ./artifacts
TAG="v${VERSION}"

# Check if release already exists and delete it (it was created without artifacts)
if gh release view "${TAG}" &>/dev/null; then
echo "Release ${TAG} already exists, deleting it to recreate with artifacts..."
gh release delete "${TAG}" --yes
fi

# Create the release with all artifacts
gh release create "${TAG}" \
--title "Release ${TAG}" \
--generate-notes \
Expand Down