fix: add shell: bash to version extraction steps#23
Merged
Conversation
thoroc
force-pushed
the
fix/release-please-outputs
branch
from
c025965 to
f32e621
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
@github-copilot Please review this PR focusing on:
- Code quality, best practices, and potential bugs
- Security vulnerabilities and unsafe patterns
- Performance implications
- Documentation accuracy and completeness
- Test coverage and edge cases
Please provide specific, actionable feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\nThe "Extract version from Cargo.toml" step failed on Windows with:\n\n
\nThe module 'VERSION=$(grep -E '^version' could not be loaded.\n\n\nThis is because Windows runners default to PowerShell, not bash.\n\n## Solution\nAddedshell: bashto both "Extract version from Cargo.toml" steps to ensure the bash commands run correctly across all platforms (Linux, macOS, and Windows).