Skip to content

Fix: fix planting-related desync#186

Open
SamuZad wants to merge 1 commit into
thomaswp:devfrom
SamuZad:feat/fix-planting-desync
Open

Fix: fix planting-related desync#186
SamuZad wants to merge 1 commit into
thomaswp:devfrom
SamuZad:feat/fix-planting-desync

Conversation

@SamuZad

@SamuZad SamuZad commented May 3, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #179, by implementing:

  1. Improving planting by passing height
  2. Making sure that the preview hides "preview plants" if the other player has no reason to see them (ie they are on a lower level or are not in "planting mode)

Without item 2, the fix would look like this:

planting_fix.mp4

Reproducing the issue

  1. Use the save file below
  2. Navigate to the area shown in the screenshot
  3. Have 1 player set their layer visibility to 9, while the other player should be looking at the place in the screenshot
  4. The player "on top" should plant above
  5. Plants will show up at layer 9

planting.zip

image

@SamuZad SamuZad force-pushed the feat/fix-planting-desync branch 2 times, most recently from 01b64e8 to 1fdf8e6 Compare May 4, 2026 11:21
@SamuZad SamuZad changed the base branch from master to dev May 4, 2026 11:22
@SamuZad SamuZad force-pushed the feat/fix-planting-desync branch 5 times, most recently from 0b22527 to 58002ad Compare May 4, 2026 13:00
@SamuZad SamuZad force-pushed the feat/fix-planting-desync branch from 58002ad to c19950a Compare May 4, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Planting operates on the receiver's current height; should be specified in the event

1 participant