Beaver name desync#169
Closed
JoeStead wants to merge 21 commits into
Closed
Conversation
* sync mechanical fluid pumps * Remove exception for invalid mode in ToActionString --------- Co-authored-by: samuzad <zadori.samu@gmail.com>
Patch NamedEntity.InitializeEntity() to use game RNG so beaver names are deterministic across server/client. Remove entity name from desync trace comparison (use entity ID only). Replaces the previous activeGamePatchers/BeaverNameServiceRandomNamePatcher approach with a simpler IsEntityInitializing flag.
matthewwachter
added a commit
to matthewwachter/BeaverBuddies
that referenced
this pull request
Apr 13, 2026
…ministic entity naming Beaver naming uses randomness that wasn't properly isolated, causing false positive desyncs. Fixes the naming RNG to be deterministic. Co-Authored-By: JoeStead
Owner
|
I think I can close this, since it's just a rebase of other PRs, right? Let me know if I missed something and it should be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes from #168
AND
#150
It would be nice to get the integration branch merged in so we can heave cleaner PRs.
I will rebase this when the upstream path is clear