feature: geom_mark_shape#343
Open
assaron wants to merge 3 commits into
Open
Conversation
Author
|
I realized that I forgot to include actual labels into the example :) Here is a better one: |
Author
|
@thomasp85 can you please check this PR? It should be relatively straightforward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi,
This is an initial take on geom_mark_shape which provides an option to manually specify polygon for the mark (issue #333).
There are two key changes:
concavity=NAin hull geometry makes it skip the hull construction step and lead to using the points as is.geom_mark_shapefunction returns the hull geometry withconcavity=NAand has different defaults from geom_mark_hull:radius=0andexpand=0.Example of the usage: