fix: e2e seed timestamps and production safety guard#72
Merged
Conversation
… guard seed-db.ts used Unix seconds but Better Auth expects timestamp_ms (milliseconds), causing all seeded dates to land in 1970 and rejecting login on ephemeral preview environments. Also adds assertSafeToSeed() to block seeding against production and updates global-setup.ts to allow seeding ephemeral PR databases.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Preview Environment
Preview URL: https://switchflag-qdkkcjiny-tom-blaymires-projects-d8765916.vercel.app
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seed-db.tsused Unix seconds but Better Auth expectstimestamp_ms(milliseconds), causing all seeded dates to land in 1970 and rejecting login on ephemeral preview environmentsassertSafeToSeed()guard to CLI entry point — blocksVERCEL_ENV=productionand only allowsfile:andlibsql://switchflag-pr-{N}-*URLsglobal-setup.tsto also seed ephemeral PR databases (passing auth token through)Test plan
pnpm --filter dashboard exec vitest run— all 984 tests passpnpm --filter dashboard test:e2elocally — seed runs withfile:DB, all personas loginTURSO_DATABASE_URL=libsql://switchflag-myorg.turso.io tsx e2e/seed-db.tsthrows FATALVERCEL_ENV=production TURSO_DATABASE_URL=file:test.db tsx e2e/seed-db.tsthrows FATALpreview-db.ymlseedsswitchflag-pr-{N}→ member user can login on preview