Skip to content

final-review adjustments (plugins): keep RSA pins across probe/reconnect, vendor/ path in README, precise noVNC errors - #23

Merged
thomasbek3 merged 1 commit into
masterfrom
round3/JS
Sep 7, 2026
Merged

thomasbek3 merged 1 commit into
masterfrom
round3/JS

Conversation

@thomasbek3

Copy link
Copy Markdown
Owner

Adjustments from the final Codex + Grok pass (Codex 1, 6; Grok 1, 3, 4). Full suite green: 58 JS, 26 HD agent, 27 orgo, 7 texting-style, installer/bind/agent-installer scripts, manifest check.

🤖 Generated with Claude Code

…ect, vendor/ path in README, precise noVNC errors

computer-viewer: every persist that spreads an endpoint now starts from
liveEndpoint() (which also falls back to a settings lookup by id), and the
backoff reconnect resolves the live endpoint at fire time, so a pin stored
on first contact survives probe success and auto-reconnect instead of being
overwritten by a pre-pin copy. A pinned computer that presents no key is
rejected. loadVendoredRFB tries vendor/novnc-rfb.mjs first, then the legacy
next-to-plugin.js location, both hash-checked; a tampered candidate stops
the search. connect() error bodies name the actual reason (hash mismatch vs
could not be loaded vs missing plus CDN blocked). README paths corrected.

bot-sections: PLUGIN_CSS rename so cssAttr reaches CSS.escape. task-dock:
observer watches aria-label and drops the dead chat-surface attributes.

9 new tests (58 JS total). Manifest regenerated.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@thomasbek3
thomasbek3 merged commit 36fc443 into master Sep 7, 2026
6 checks passed
@thomasbek3
thomasbek3 deleted the round3/JS branch September 7, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant