Improve browser smoke failure diagnostics - #395
Merged
Merged
Conversation
- Include page errors and failed requests in startup and reload failures - Verify reset diagnostics and external target restoration
- Reduce Windows socket pressure and remove Python from browser fixtures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Include captured page errors and failed requests in browser smoke failures, including startup and reload timeouts. Ignore normal navigation cancellations, and make the external-server reload check wait for a restored inference target before asserting its identity.
Scope
Limited to browser smoke diagnostics, the external-server reload assertion, and related test documentation. No UI changes.
Verification
Not run. The change request describes the diff; verification commands were not provided.