fix(checkpoint): support tinker paths with run-id suffix#34
Open
Jah-yee wants to merge 1 commit into
Open
Conversation
Fixes Issue thinking-machines-lab#24: 'tinker checkpoint delete' now accepts paths with run-id suffix (e.g., tinker://run-id:train:0/sampler_weights/final). The previous implementation assumed a strict 3-part path format, which failed when the run-id contained a suffix like ':train:0'. This change updates ParsedCheckpointTinkerPath.from_tinker_path() to: - Handle run-ids with arbitrary suffixes - Provide better error messages for invalid formats Good day, Thank you for your work on this excellent library! Warmly, RoomWithOutRoof
Author
|
Good day 👋 Just checking in! This PR adds support for tinker paths with run-id suffix, which should make checkpoint path handling more flexible. Any chance to take a look when you have time? Thank you for your work and happy coding! 🚀 Warmly, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #24:
tinker checkpoint deletenow accepts paths with run-id suffix (e.g.,tinker://run-id:train:0/sampler_weights/final).Good day,
Thank you for your work on this excellent library!
Warmly,
RoomWithOutRoof