feat: switch to using rumqttc fork to resolve potential security issues#4145
Draft
reubenmiller wants to merge 1 commit intothin-edge:mainfrom
Draft
feat: switch to using rumqttc fork to resolve potential security issues#4145reubenmiller wants to merge 1 commit intothin-edge:mainfrom
reubenmiller wants to merge 1 commit intothin-edge:mainfrom
Conversation
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
reubenmiller
commented
Apr 24, 2026
Comment on lines
+172
to
+173
| fn set_pending(&mut self, _requests: Vec<Request>) { | ||
| // No-op: pending management is handled internally by the fork's EventLoop. |
Contributor
Author
There was a problem hiding this comment.
This is an unacceptable change! The fork no longer gives us access to the status, so we'll have to access if there is another way to provide the logging.
reubenmiller
commented
Apr 24, 2026
| authors = ["thin-edge.io team <info@thin-edge.io>"] | ||
| edition = "2021" | ||
| rust-version = "1.85" | ||
| rust-version = "1.89" |
Contributor
Author
There was a problem hiding this comment.
Switching to the fork requires bumping the MSRV
reubenmiller
commented
Apr 24, 2026
Comment on lines
+77
to
+79
| { id = "RUSTSEC-2026-0049", reason = "crate: rustls-webpki 0.102.x. Used by rumqttd (test-only broker) which pins ^0.102.x; incompatible with the fixed 0.103.10. No fix available in the 0.102.x line" }, | ||
| { id = "RUSTSEC-2026-0098", reason = "crate: rustls-webpki 0.102.x. Used by rumqttd (test-only broker) which pins ^0.102.x; no fix in the 0.102.x line" }, | ||
| { id = "RUSTSEC-2026-0099", reason = "crate: rustls-webpki 0.102.x. Used by rumqttd (test-only broker) which pins ^0.102.x; no fix in the 0.102.x line" }, |
Contributor
Author
There was a problem hiding this comment.
To address these, we'll probably need to fork the rumqtt (upstream) project, and just update the rumqttd components ourselves...this should be a lower risk/impact since we only use it for tests.
|
Hi @reubenmiller, I saw this linked over at my issue. Anything you need help with from my end? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Switch to using a rumqttc fork (https://github.com/thehouseisonfire/rumqtt). There is a discussion here on the upstream project about the need for a fork, bytebeamio/rumqtt#1029.
Currently below shows the impact of switching to the fork (it may be incomplete):
Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments