Skip to content

chore: Use cargo-binstall to install tools#4137

Merged
didier-wenzek merged 2 commits intothin-edge:mainfrom
jarhodes314:chore/binstall-tools
May 4, 2026
Merged

chore: Use cargo-binstall to install tools#4137
didier-wenzek merged 2 commits intothin-edge:mainfrom
jarhodes314:chore/binstall-tools

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

Proposed changes

Switch from cargo install to cargo binstall for build dependencies installed by just install-tools, which will grab them from github releases

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread justfile
cargo +stable install --locked cargo-nextest
cargo +stable install --locked cargo-deny

# Install taplo by downloading the pre-compiled binary directly from GitHub releases
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming cargo binstall did not work for taplo despite seeing some references to cargo binstall support in their documentation. What is it lacking? May be worth adding as a comment.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the documentation is for the @taiki-e/action, which is just the generic github action to install rust tools, not taplo.

I don't know for sure what a crate needs to work with cargo-binstall, but it's pretty obvious from the output (and the time taken) if you hit an incompatibility, you can see from the install-tools execution here that we both get a warning saying taplo will be built from source and see the cargo output as it builds too: https://github.com/thin-edge/thin-edge.io/actions/runs/24523086774/job/7168591738. I'll add a comment mentioning that it doesn't work with cargo-binstall, but don't have much more to say than that.

@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label Apr 17, 2026
@jarhodes314 jarhodes314 force-pushed the chore/binstall-tools branch from 6f932aa to eb695fb Compare April 20, 2026 14:30
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request April 20, 2026 14:30 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
911 0 4 911 100 2h41m10.63213s

Comment thread justfile Outdated
@reubenmiller reubenmiller added the skip-release-notes Don't include the ticket in the auto generated release notes label Apr 22, 2026
@didier-wenzek didier-wenzek enabled auto-merge April 24, 2026 11:40
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@jarhodes314 jarhodes314 force-pushed the chore/binstall-tools branch from a758ec9 to 645b162 Compare April 27, 2026 15:27
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request April 27, 2026 15:27 — with GitHub Actions Inactive
@didier-wenzek didier-wenzek added this pull request to the merge queue May 4, 2026
Merged via the queue into thin-edge:main with commit e7f31dc May 4, 2026
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Repository management and pipeline topics skip-release-notes Don't include the ticket in the auto generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants