chore: Use cargo-binstall to install tools#4137
chore: Use cargo-binstall to install tools#4137didier-wenzek merged 2 commits intothin-edge:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
| cargo +stable install --locked cargo-nextest | ||
| cargo +stable install --locked cargo-deny | ||
|
|
||
| # Install taplo by downloading the pre-compiled binary directly from GitHub releases |
There was a problem hiding this comment.
I'm assuming cargo binstall did not work for taplo despite seeing some references to cargo binstall support in their documentation. What is it lacking? May be worth adding as a comment.
There was a problem hiding this comment.
The link to the documentation is for the @taiki-e/action, which is just the generic github action to install rust tools, not taplo.
I don't know for sure what a crate needs to work with cargo-binstall, but it's pretty obvious from the output (and the time taken) if you hit an incompatibility, you can see from the install-tools execution here that we both get a warning saying taplo will be built from source and see the cargo output as it builds too: https://github.com/thin-edge/thin-edge.io/actions/runs/24523086774/job/7168591738. I'll add a comment mentioning that it doesn't work with cargo-binstall, but don't have much more to say than that.
6f932aa to
eb695fb
Compare
Robot Results
|
eb695fb to
a758ec9
Compare
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Signed-off-by: James Rhodes <jarhodes314@gmail.com> Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
a758ec9 to
645b162
Compare
Proposed changes
Switch from
cargo installtocargo binstallfor build dependencies installed byjust install-tools, which will grab them from github releasesTypes of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments