docs(handoff): clôturer le handoff de session — bug de langue corrigé et mergé - #260
Merged
Merged
Conversation
The handoff still described #258 as in flight and carried the pre-merge state. Updated to the closed picture: seven PRs merged, working tree clean, no open PR. Bug 1 is closed. The shipped fix and, more usefully, the reason it could not live in the middleware are recorded so nobody retries that layer: Next canonises RSC requests before middleware runs, stripping both the prefetch headers and the ?_rsc param, so a prefetch and a real navigation are indistinguishable there. The ResponseCookies ordering trap is kept too. The remaining work is now explicit and ordered, including the P0 the i18n audit surfaced (unprefixed server redirects lose the locale — arbitrated, follow-up PR), the mobile nav gap @Thierry chose to defer to Phase 1 rather than patch, and the pre-existing Settings locale select and SEO canonical bugs. Mirrored to the Obsidian vault per the double-redundancy rule.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🧙 Sourcery a terminé la revue de votre pull request ! Conseils et commandesInteragir avec Sourcery
Personnaliser votre expérienceAccédez à votre tableau de bord pour :
Obtenir de l’aide
Original review guide in English🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Salut - j’ai examiné tes modifications et elles sont excellentes !
Sourcery est gratuit pour l’open source - si tu aimes nos revues, merci d’envisager de les partager ✨
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Le handoff décrivait encore #258 comme en vol. Mis à jour sur l'état clos : 7 PR mergées, working tree propre, aucune PR ouverte.
Bug 1 fermé. Le correctif livré est consigné, mais surtout la raison pour laquelle il ne pouvait pas vivre dans le middleware — pour que personne ne retente cette couche : Next canonise les requêtes RSC avant l'exécution du middleware, en retirant à la fois les en-têtes de prefetch et le paramètre
?_rsc, donc un prefetch et une navigation réelle y sont indiscernables. Le piège d'ordonnancementResponseCookiesest conservé également.Le reste à faire est désormais explicite et ordonné : le P0 remonté par l'audit i18n (les redirections serveur non préfixées perdent la langue — arbitré, PR de suivi), le trou de nav mobile que @Thierry a choisi de reporter en Phase 1 plutôt que de patcher, et les défauts préexistants du sélecteur de langue des Réglages et des canoniques SEO.
Miroir dans le vault Obsidian, conformément à la règle de double redondance.
Documentation uniquement — 1 fichier, 0 ligne de code.
Summary by Sourcery
Documentation :
Original summary in English
Summary by Sourcery
Documentation:
Original summary in English
Summary by Sourcery
Documentation :
Original summary in English
Summary by Sourcery
Documentation: