chore(lint): add GolangCI-Lint integration and Makefile targets#48
Merged
Conversation
Contributor
Author
ccoVeille
reviewed
Jul 9, 2025
Contributor
ccoVeille
left a comment
ccoVeille
left a comment
There was a problem hiding this comment.
I would expect golangci-lint to be launched with GitHub Actions then.
It can be addressed with another PR, of course.
But for now, this is great
ccoVeille
reviewed
Jul 9, 2025
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
This was
linked to
issues
Jul 9, 2025
Closed
Closed
Member
|
Hi @ZwangaMukwevho, thank you for setting this up and correcting the present issues! I'll have a detailed look tomorrow or on Friday. Thank you for your valuable insights @ccoVeille as well! It should definitely be part of the CI/CD - I think we will handle that internally as only we have access to running the pipelines. |
krixlion
requested changes
Jul 15, 2025
Contributor
krixlion
left a comment
krixlion
left a comment
There was a problem hiding this comment.
Very nice PR, I'll be happy to approve once my comments are addressed.
Co-authored-by: Konstanty Cyran <96084033+krixlion@users.noreply.github.com>
…to add-golangci-lint
Contributor
Author
Addressed the comments, feel free to have a look |
krixlion
reviewed
Jul 16, 2025
krixlion
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, make sure the boxes below are ticked:
golangci-lint run) and fixed any issues.Make sure to check the boxes below if they are applicable to the given situation (of course, it is not necessary to write tests when updating README etc.):
Issue addressed:
42