Repository navigation
fix(a13): wire release provenance through the variant API - #18
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
正式模式把 Provider 直接传给 Android SourceSet.assets，AGP 9.4 在配置阶段拒绝，导致两次 Signed Build 尚未产生候选 Artifact 就失败。使用不存在的占位 keystore 和 --dry-run 已准确复现；普通无签名 CI 不会进入该分支。
将来源证明生成器改为带声明输入/输出的任务，通过 AGP Variant API 的 assets.addGeneratedSourceDirectory 接入，自动建立生成到 assets 合并的依赖。保持来源文件字节格式、完整 SHA、版本、包名及所有签名/来源门禁；使用官方支持的接口，不调整构建工具版本或 Provider 限制。
Fast/Full 新增无密钥的正式任务图检查：仅以占位配置执行 --dry-run，确保来源生成先于 assets 合并和打包，并包含 lint。不会读取真实私钥、执行 APK 打包或签名。Signed Build 的 main CI 检查同时要求这一步真实 success。
验证：正式任务图检查通过；实际运行来源生成任务并核对完整 SHA、r13.14.1/142、release 和应用 ID（只用占位配置，无 APK）；本地 Fast/Full、944 项 Python（4 既有 skipped）、compileall、CI 可移植性、814 文件编码及 diff-check 通过。Android 运行时代码、版本与证书保持。
这是维护者在 PR #16 后追加的发行流程调整。Base: a9bf3bf。
参考：https://developer.android.com/reference/tools/gradle-api/9.4/com/android/build/api/variant/SourceDirectories.Flat