Repository navigation
fix(a13): close core maintenance and prepare protected r13.14.0 releases - #15
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
thetvplus
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f9363b385
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _, previous_code = source_version(source_file("app/build.gradle.kts", latest["target_commitish"])) | ||
| require(metadata["version_code"] > previous_code, "versionCode must increase from the latest release") |
There was a problem hiding this comment.
If the latest existing release has target_commitish set to main rather than an immutable commit SHA, this lookup reads the candidate's current source instead of the previous release's source. Since current_main() has just confirmed that main points to the candidate, previous_code equals the candidate's versionCode and promotion stops with versionCode must increase from the latest release, even for a legitimate version increase. Resolve the previous release's tag_name to its tagged commit and read the version from there instead of using its potentially moving target branch.
Useful? React with 👍 / 👎.
在 r13.13.0 基础上收口 A13 核心 Hook、Launcher 手势与设置页面，并准备 r13.14.0（142）的独立受保护签名和发布流程。本 PR 不触发正式签名或公开发行。
验证：本地 Fast/Full、1325 项 JVM 测试（1 skipped）、lint（0 errors / 696 warnings）、R8、936 项 Python 测试（4 skipped）、actionlint 1.7.12、结构化工作流合同和差异检查通过。新增 40 项发布工程回归；特殊密码通过实际 Java Properties round trip；正式构建缺少签名配置时实测在组装前拒绝。现行两仓 r13.13.0 APK 的文件 hash 和证书已下载核验一致。
未执行正式 assembleRelease、GitHub attestation 或新版本发布；需最终 main 的完整 CI 及 Environment 人工审批。无本轮 A13 日志/实机验收，SecurityCenter 11.1.6 仍缺实际样本，Issue #14 未全部解决，音乐可视化和扩展电源菜单保持 RETIRE_CANDIDATE。
Base: 09b63af。PR 原提交 6126707，本轮新增 6f9363b；总计 2 个工作提交，按任务授权在检查通过后 Squash merge。