alsa_settings: WCL platform settings#1298
Conversation
Create WCL platform ALSA settings state files for: * WCL_HDA_AIOC * WCL_SDW_RT712 * WCL_RVP_SDW The parameters in the state files are explicitly set even if the default values at the appropriate DUT are currently the same. Signed-off-by: Mateusz Junkier <mateusz.junkier@intel.com>
marc-hb
left a comment
There was a problem hiding this comment.
As usual I wonder why these are not already the default.
The parameters in the state files are explicitly set even if
the default values at the appropriate DUT are currently the same.
Does that mean tests should pass even when all other users have bad settings?
i believe most discussion was in PR1294 and PR1270 . In summary, some tests may modify ALSA settings without restoring defaults, which can lead to failures |
There are (at least) two different questions:
The general answer to 1. is easy and well-known: in general each test should CLEAN-TEST-CLEAN. The first clean is for itself, the second clean is for other users: either interactive users or to help "bad" tests (which should be fixed eventually). EDIT: there are optimization trade-offs; you cannot reboot before every test. I don't think 1. is relevant to this PR. This PR is about 2.
Yes, and based on the discussion there, why is |
Create WCL platform ALSA settings state files for:
The parameters in the state files are explicitly set even if the default values at the appropriate DUT are currently the same.