fix: 检查遗漏的旧app图标,换用新版TriFecta app图标并取消输入方案设置页下的注释。 - #10
Merged
Conversation
Owner
|
感谢提交!✅ 我已核验:
由于最近忙着收拾行李赶高铁,这次先只合并,这批图标/文案改动会进入下一个版本。 辛苦了!👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容
新图标 resources/RimeIcon.icns(从 icon.png 生成,16~1024 共 10 尺寸),后续 Dock / Sparkle 弹窗 / 设置窗口 / Finder 图标统一
移除未完成的 Rime.icon 旧图标工程,并删掉 pbxproj 中 4 处 ASSETCATALOG_COMPILER_APPICON_NAME(否则构建仍会用旧图标覆盖)
设置面板关于页改用新版app图标
设置面板中输入方案行与添加方案弹窗里的灰色实现文件名已移除,界面更干净
settings/scripts/build-app.sh 图标源对齐 RimeIcon.icns
测试
make release 通过,codesign --verify --deep --strict 通过
icns 10 尺寸齐全,与 icon.png 视觉一致
菜单栏图标 rime.pdf 未动(另行讨论)