device: add optional printerCode field for in-protocol model identification#1
Open
mannes wants to merge 1 commit into
Open
device: add optional printerCode field for in-protocol model identification#1mannes wants to merge 1 commit into
mannes wants to merge 1 commit into
Conversation
In-protocol model identifier returned by a device's identity query. Used by transport-agnostic autodetect: open wire → ask printer who it is → look up by code. Single code or array of codes (some chassis report multiple IDs across firmware revisions). Niimbot is the only consumer today, mapping PrinterInfo(0x08) replies through niimbluelib's modelsLibrary. Other drivers can opt in when they grow an equivalent query; Brother / Dymo / cat-printer stay on USB VID/PID and leave the field absent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
printerCode?: number | readonly number[]field onDeviceEntry. The field carries the device-reported model identifier returned by a driver-specific identity query, used by transport-agnostic autodetect: open wire → ask printer who it is → look up by code.Niimbot is the only consumer today, mapping
PrinterInfo(0x08)replies through niimbluelib'smodelsLibrary. Single chassis may report multiple IDs across firmware revisions, hence the array shape. Brother / Dymo / cat-printer have no equivalent query and leave the field absent.See thermal-label/niimbot's
feat/niimbot-autodetectbranch for the consumer (identifyNiimbot+findDeviceByPrinterCode).🤖 Generated with Claude Code