Repository navigation
Assessment Module Rule Update - #2938
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
adelowo
marked this pull request as ready for review
October 26, 2026 09:52
adelowo
force-pushed
the
feat-ISS-3322
branch
from
October 26, 2026 09:54
7fdad64 to
45a0822
Compare
adelowo
force-pushed
the
feat-ISS-3322
branch
from
October 26, 2026 10:44
45a0822 to
55a66c7
Compare
adelowo
enabled auto-merge (squash)
October 26, 2026 12:26
| } | ||
|
|
||
| func getPurposesFromMutation(ctx context.Context, m *generated.CustomDomainMutation) ([]enums.DomainPurpose, error) { | ||
|
|
Member
There was a problem hiding this comment.
We should only need this on create because if the addon is removed, we'd want to delete the custom domain.
golanglemonade
approved these changes
Oct 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enforces modules based off the type of custom domain being created. prevents an issue where orgs having only one module type may grant them access to all available domain types
also
task regenerate