ci: build Docker image on chart-releaser tags#36
Merged
Conversation
The Release workflow only triggered on v* tags, but chart-releaser tags the Helm chart as klag-<version>. Bumping the chart to 0.1.12 created a klag-0.1.12 tag (not v0.1.12), so themoah/klag:0.1.12 was never built. ArtifactHub then failed scanning the image referenced by the chart. - trigger Release on klag-* tags too - for klag-* tags, derive image version from appVersion in build.gradle.kts - always cut the app release as v<version> to avoid colliding with the klag-<version> chart tag Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Standardize on bare semver for both image tags and GitHub releases (no v prefix), and make version resolution work for any tag form. - trigger on klag-* and plain semver tags (drop the v* convention) - derive version by stripping any tag prefix (klag-, v) to the bare semver - release tag_name is the bare version, matching the image tag Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ArtifactHub fails scanning the chart's referenced image:
The
Releaseworkflow (Docker build/push) only triggered onv*tags. Buthelm-release.yml's chart-releaser tags the chart asklag-<version>. Bumping the chart to 0.1.12 created tagklag-0.1.12(notv0.1.12), sorelease.ymlnever ran andthemoah/klag:0.1.12was never built. Last image built wasv0.1.10;0.1.11and0.1.12are both missing on Docker Hub and GHCR. Chart.yaml'sartifacthub.io/imagesannotation points at the non-existent0.1.12.Fix
Releaseonklag-*tags too, so a chart release also builds the matching image.klag-*tags, derive the image version fromappVersioninbuild.gradle.kts(source of truth) rather than the chart-version tag.v<version>to avoid colliding with theklag-<version>chart tag.Result: chart bump → image auto-built; no more drift between chart appVersion and published image.
Follow-up (not in this PR)
The missing
0.1.12image still needs a one-time build:After that, ArtifactHub's next rescan passes.
🤖 Generated with Claude Code