Skip to content

Fix: Robustness for dates and missing values in aligned dataframes which are commonly produced from OMOP - #304

Draft
eroell wants to merge 1 commit into
mainfrom
fix/write-omop-increased-robustness
Draft

eroell wants to merge 1 commit into
mainfrom
fix/write-omop-increased-robustness

Conversation

@eroell

@eroell eroell commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Fix #303

@Zethson Zethson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be solved on this level or on the OMOP reader level?

@eroell

eroell commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

Tend to fix here.
There's also other ways to write dates into ehrdata's dataframes. And they are also useful to treat as dates, for e.g. sorting.
Writing these objects is somewhat annoying. I have a bunch of "for column in edata.obs" lines in my analyses already, but did not yet want to commit having this a fixed way of writing. That OMOP will usually fail to write convinces me that this should work without user workarounds now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

write_h5ed cannot write the output of io.omop.setup_obs

2 participants