Draft
Conversation
Contributor
Author
|
To do list:
|
jason0x43
reviewed
Mar 12, 2019
Member
jason0x43
left a comment
jason0x43
left a comment
There was a problem hiding this comment.
Looking good, I just had a few suggestions and comments
src/WebDriverProxy.ts
Outdated
| @@ -0,0 +1,297 @@ | |||
| import * as express from 'express'; | |||
| import * as request from 'request'; | |||
Member
There was a problem hiding this comment.
Could we use request from @theintern/common since that's already a dep?
Contributor
Author
There was a problem hiding this comment.
I'll have to refactor my proxying function.
Contributor
Author
There was a problem hiding this comment.
I refactored the code to use request from @theintern/common. I created a PR, theintern/common#4, for a small change to common.
This was referenced Mar 15, 2019
jason0x43
reviewed
Mar 22, 2019
package.json
Outdated
| "@theintern/dev": "~0.9.0", | ||
| "@types/decompress": "~4.2.2", | ||
| "@types/node": "~9.6.11", | ||
| "@types/request": "^2.48.1", |
Member
There was a problem hiding this comment.
We probably don't need this anymore
edhager
force-pushed
the
issue-54-webdriver-binaries-config
branch
2 times, most recently
from
e99e90e to
5f12312
Compare
edhager
force-pushed
the
issue-54-webdriver-binaries-config
branch
3 times, most recently
from
1f9f612 to
2a145c2
Compare
edhager
force-pushed
the
issue-54-webdriver-binaries-config
branch
from
2a145c2 to
7ef2c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new Intern tunnel that runs the various browsers' web driver servers without using Selenium or Java.
Fixes #54