Skip to content

fix(deps): patch security advisories in rust and npm deps - #2413

Merged
ctrlc03 merged 2 commits into
mainfrom
chore/security-deps
Nov 2, 2026
Merged

ctrlc03 merged 2 commits into
mainfrom
chore/security-deps

Conversation

@ctrlc03

@ctrlc03 ctrlc03 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

This PR bumps dependencies that have security advisories published between August and November 2026. osv-scanner found them in this repo.

Rust lockfiles (Cargo.lock, crates/openvm-prover/Cargo.lock, templates/default/Cargo.lock)

Crate From → to Advisory
rustls-webpki 0.103.13 → 0.103.16 CVE-2026-111943: the trust store still included the distrusted emSign intermediates
webpki-roots, webpki-root-certs 1.0.5 / 1.0.9 → 1.0.11 CVE-2026-111943 (emSign ECC Root CA - G3 removed)
rustls 0.23.36 / 0.23.40 → 0.23.46 RUSTSEC-2026-0285, -0346, -0348, -0349
zstd / zstd-safe / zstd-sys 0.13.3 / 7.2.4–7.3.0 / 2.0.16–2.1.0 → 0.13.4 / 7.4.0 / 2.1.2 RUSTSEC-2026-0391, -0395 … -0406, -0410 (use-after-free, OOB, double free)
crypto-bigint 0.7 / ctutils 0.7.5 / 0.4.2 → 0.7.10 / 0.4.8 RUSTSEC-2026-0387, RUSTSEC-2026-0385: constant-time operations had timing variability. 0.7.6 has been yanked

npm (pnpm-lock.yaml)

Not fixed: crypto-bigint 0.5.5 (RUSTSEC-2026-0387). elliptic-curve 0.13 pins it, through k256 0.13, ecdsa 0.16, alloy-signer and openvm-ecc-guest. Clearing it needs the elliptic-curve 0.14 migration upstream. Guest lockfiles are untouched.

Verification

  • E3_ZK_PROVER_SKIP_FIXTURE_BUILD=1 cargo check --workspace --locked: pass.
  • cargo check in templates/default and crates/openvm-prover: pass. openvm-prover was checked with SDKROOT set to the macOS 26.5 SDK, to get around a local Xcode SDK problem.
  • pnpm -F @interfold/mcp build and tsc --noEmit: pass.
  • docs: pnpm build passes on Next 15.5.28.
    • Under next start, /, /learn, /learn/what-is-e3 and /whitepaper return 200.
    • Old URLs redirect to their new pages: /introduction → /learn, /ciphernode-operators/running → /operate/running.
    • KaTeX renders on /learn/cryptography.
  • An osv-scanner re-scan finds none of the advisories above, apart from crypto-bigint 0.5.5.

Compatibility

Protocol review: no protocol effect.

  • The crypto-bigint 0.7 and ctutils dependencies come only through Noir's acvm_blackbox_solver ECDSA opcodes. No circuit uses them, so witnesses, proofs and VKs are unchanged.
  • The bundled libzstd is still 1.5.7, with byte-identical sources. zstd is used only for HTTP compression and OpenVM's internal STARK decoding.
  • libp2p-tls uses its own certificate verifier, so the peer wire format is unchanged.
  • Guest programs, image IDs, protocol-release.toml and vk-commitments.json are untouched.

Release follow-up: the root Cargo.lock feeds the circuit SOURCE_HASH (crates/zk/build/src/identity.rs), so this bump changes the hash for every circuit pair. The circuit artifacts themselves don't change. Before the next release, rebuild the circuits and push them to circuit-artifacts for the new hash, or download-circuits in releases.yml won't find a match.

Summary by CodeRabbit

  • Chores
    • Updated the tooling used to support browser-based testing, documentation-site builds, and image processing. These maintenance changes keep development and publishing workflows current; they do not change the features or behavior available in the product. No new user-facing functionality is included in this update.

Bump rustls, rustls-webpki, webpki-roots/webpki-root-certs (CVE-2026-111943), zstd*, crypto-bigint 0.7, ctutils; docs next 15.5.28 + sharp 0.35.5; @modelcontextprotocol/sdk 1.32.2; playwright 1.64.1; dompurify 3.4.17.
@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interfold-dashboard Ready Ready Preview Nov 2, 2026 10:42pm UTC
interfold-docs Ready Ready Preview Nov 2, 2026 10:42pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4f8271e and cb5fe03.

Files ignored due to path filters: 4
  • Cargo.lock is excluded by !**/*.lock
  • crates/openvm-prover/Cargo.lock is excluded by !**/*.lock
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • templates/default/Cargo.lock is excluded by !**/*.lock
Files selected for processing: 3
  • crates/wasm/package.json
  • docs/package.json
  • packages/interfold-mcp/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Three package manifests update dependency versions: Playwright for WASM, Next.js and Sharp for the documentation site, and the Model Context Protocol SDK for the MCP package.

Changes: Dependency version updates

Layer / File(s) Summary
Update package dependency versions
crates/wasm/package.json, docs/package.json, packages/interfold-mcp/package.json
Playwright changes from 1.52.0 to 1.64.1. Next.js changes from ^14.2.1 to ^15.5.28, and Sharp changes from ^0.34.1 to ^0.35.5. The Model Context Protocol SDK changes from ^1.10.2 to ^1.32.2.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: hmzakhalid, neogiacomo

Merge Risk: Minimal · up to cb5fe

The dependency updates present no established merge-blocking issue in the supplied evidence. Merge after normal checks, retaining the documented circuit rebuild and publication step before the next release.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: patching security advisories in Rust and npm dependencies.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

crates/wasm/package.json

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

docs/package.json

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

packages/interfold-mcp/package.json

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ctrlc03
ctrlc03 merged commit 12e6998 into main Nov 2, 2026
44 checks passed

This branch was successfully deployed

2 active deployments
Preview – interfold-dashboard — cb5fe03a Deployed Nov 2, 2026 by vercel[bot]
Preview – interfold-docs — cb5fe03a Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant