Conversation
Co-authored-by: Copilot <copilot@github.com>
MrTheronJ
approved these changes
Apr 27, 2026
| record.gene_codes["rpoB"].max_mdl_variants = [v] | ||
| processor.resolve_drug_target(record) | ||
| assert record.drug_target_value == "No mutations associated with resistance to rifampicin detected" | ||
| assert record.drug_target_value == "Predicted susceptibility to rifampicin" |
Contributor
There was a problem hiding this comment.
I think we should establish a practice for modifying existing test cases, especially as things get more complex. My first thought was to start commenting out the original assertion and link the PR/version it was changed in. That way, future us will have a clear reference for when and why it was originally updated. What do you think? Is that overkill?
| f"{v.protein_change if v.protein_change != 'NA' else v.nucleotide_change}" | ||
| f"{' [synonymous]' if self._is_synonymous_rpob_rrdr(v) else ''}" | ||
| for v in gene_code.max_mdl_reportable_variants | ||
| list(set( |
Contributor
There was a problem hiding this comment.
I remember last week you brought up a good question about whether these AA's should be sorted (by position). Might be unnecessary right now, but just wanted to bring it up again. Thoughts?
Pros:
- looks good? better than random order?
Cons:
- might make comparing diffs more complicated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the WT rpoB change and removes duplicate AA from LIMS report.