Open
Conversation
* Feature: Update search to use PageFind for indexing and retrieval. - Adds the `pagefind` library and `removes` lunr - Updates the search plugin to index HTML pages and figures using a new `SearchIndex` class - Output the search index to `_search` along with the frontend API files that PageFind builds - Adds pagefind data attributes as meta tags and on `.quire-page` to pass page metadata to the index - Updates the existing search UI to use the pagefind API - Adds the Sinon library for creating test mocks - Adds tests for SearchIndex using mocks for the pagefind methods - Bundles the pagefind search API and imports it when `loadSearchData` is called, so pagefind will load the index using wasm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-stages #1084 for review and QA against the rewound branch.
That PR's details:
pagefindlibrary andremoveslunrSearchIndexclass_searchalong with the frontend API files that PageFind builds.quire-pageto pass page metadata to the indexloadSearchDatais called, so pagefind will load the index using wasm.