Repository navigation
Conversation
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Provide the v4 migration path for the field rename requested in #1229.
Approach
Add
causeas a non-enumerable, read-only alias oferror, and deprecateerror. Keepcauseoptional inResult<T>so existing object literals remain valid. Error wrapping and unboxing stay compatible with v4.Coverage includes alias identity, changes through
error, legacy results, andallSettled(). Local Deno tests, lint, formatting, type checks, and the Node test build pass.Fix CI by naming the benchmark package to prevent npm's audit crash.