Skip to content

⬆️ Update benchmark Effect dependencies to patched releases - #1262

Open
cowboyd wants to merge 2 commits into
v4from
fix/codspeed-no-audit
Open

cowboyd wants to merge 2 commits into
v4from
fix/codspeed-no-audit

Conversation

@cowboyd

@cowboyd cowboyd commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Motivation

CodSpeed benchmark dependency installation fails silently with npm auditing enabled. The pinned Effect versions also carry known vulnerabilities: Effect v3 has an AsyncLocalStorage context isolation advisory, and the Effect v4 beta depends on a vulnerable TOML parser.

Approach

Update the pinned comparison libraries from Effect 3.14.0 to 3.22.4 and from Effect 4.0.0-beta.64 to 4.1.1. Both fixes are available upstream; no dependency overrides are needed. Keep npm auditing enabled and remove the redundant second install.

These updates change the Effect comparison baselines, while preserving their benchmark names.

Validation:

  • Fresh temporary dependency installation succeeds with auditing enabled and reports zero vulnerabilities.
  • Explicit npm audit --json reports zero vulnerabilities.
  • All four Effect scenarios pass at the configured benchmark depths (recursion 100, events 10).
  • Formatted both changed files with Deno and ran git diff --check. No TypeScript files changed.

The temporary validation uses an existing local Effection npm build; the GitHub workflow rebuilds the package from the checkout.

@codspeed

codspeed Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing fix/codspeed-no-audit (7f45da3) with v4 (b1e1f5f)

Open in CodSpeed

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Deploy Preview Ready!

@cowboyd cowboyd changed the title 🔧 Disable npm audit during benchmark installation ⬆️ Update benchmark Effect dependencies to patched releases Nov 1, 2026
@pkg-pr-new

pkg-pr-new Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/effection@1262

commit: 7f45da3

This branch was successfully deployed

1 active deployment
Preview — 7f45da37 Deployed Nov 1, 2026 by cowboyd via deploy-preview #1440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant