Repository navigation
Conversation
Contributor
|
🚀 Deploy Preview Ready!
|
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CodSpeed benchmark dependency installation fails silently with npm auditing enabled. The pinned Effect versions also carry known vulnerabilities: Effect v3 has an AsyncLocalStorage context isolation advisory, and the Effect v4 beta depends on a vulnerable TOML parser.
Approach
Update the pinned comparison libraries from Effect 3.14.0 to 3.22.4 and from Effect 4.0.0-beta.64 to 4.1.1. Both fixes are available upstream; no dependency overrides are needed. Keep npm auditing enabled and remove the redundant second install.
These updates change the Effect comparison baselines, while preserving their benchmark names.
Validation:
npm audit --jsonreports zero vulnerabilities.git diff --check. No TypeScript files changed.The temporary validation uses an existing local Effection npm build; the GitHub workflow rebuilds the package from the checkout.