Skip to content

Severe overweighting of RecDev penalty, fixed in 745a725 #28

Description

@gavinfay

@sgaichas @MaC-Perez I had been puzzled at the large nLL for the recruitment penalties.

Turns out I was populating a vector of length Nrecdevs * Nspp with the SUM of the nLL for each recruitment deviation, and then summing those. e.g. effectively upweighting the recdevs by a factor of 400. Oops.
This is due to the version of dnorm() that gets called with a dvar_vector resid and a dvar_vector std.dev. (ie it returns the sum not the individual nLLs)

Fixed in commit 745a725. Sorry about this!
image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions