feature: Support wall-clock timers in addition to relative ones - #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
Added
ITimerService.StartSingleShot(DateTimeOffset deadline, Func<Task> callback, string? discriminator = null):wall-clock deadline timers. The wall clock is re-read on every wake-up, so a backward clock step
(e.g. NTP stepping) cannot make a timer fire before its deadline. Guarantee is never early only —
a forward step means the timer is already late and fires on wake-up.
TimerReference.Deadline(DateTimeOffset?), non-null for deadline timers.FakeTimerServicesupports deadline timers; firing stays manual viaExecuteAsync/ExecuteAllAsync.TimerServiceaccepts an optionalTimeProvider(test seam, defaults toTimeProvider.System).Microsoft.Bcl.TimeProviderfornetstandard2.0only.Changed
TimerReference.Timeoutwidened fromTimeSpantoTimeSpan?; it is null for deadlinetimers. Exactly one of
TimeoutandDeadlineis non-null. Source- and binary-breaking for anycode reading
Timeout.ITimerServicegained a member. Third-party implementations must implement the deadlineoverload; a default interface implementation is not possible on
netstandard2.0.StartSingleShot(TimeSpan, ...)overload is unchanged and keeps its monotonic guarantee.Both overloads now document which clock domain their guarantee lives in.
timeout <x>ordeadline <t>.Removed
FakeTimerService.StartSingleShot(TimeSpan, Func<Task>), the Capsule.Core 3.0.0compatibility overload. Source-compatible (calls bind to the optional-parameter overload), but
binary-breaking for assemblies compiled against Capsule.Testing 3.0.0 — recompile.