Skip to content

fix: keep the git autocommit notice off stdout in the stdio transport - #44

Merged
thecodacus merged 1 commit into
mainfrom
fix/stdio-stdout-log
Oct 12, 2026
Merged

thecodacus merged 1 commit into
mainfrom
fix/stdio-stdout-log

Conversation

@thecodacus

@thecodacus thecodacus commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Follow-up to #26. On the stdio transport stdout carries the MCP protocol, and the "git autocommit: enabled" startup notice was written with console.log, so with GIT_AUTOCOMMIT=true a plain-text line went out on the protocol stream before the first message.

It now goes to stderr like every other log line in stdio.ts.

Checked by running the stdio server with GIT_AUTOCOMMIT=true and capturing stdout: one stray line before the change, nothing after, and a client handshake lists the tools as usual.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Git autocommit startup confirmations now appear on stderr when Git readiness succeeds.

On the stdio transport stdout is the MCP protocol stream. With
GIT_AUTOCOMMIT=true the startup notice was written with console.log
and landed on that stream ahead of the first protocol message.
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 55d45d09-23e5-479b-81e8-b9e8b0d24ec8

📥 Commits

Reviewing files that changed from the base of the PR and between dfecee9 and aeb9e96.


📒 Files selected for processing (1)
  • packages/server/src/mcp/stdio.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

When Git autocommit is enabled and Git readiness succeeds, the startup confirmation is written to stderr instead of stdout. The readiness failure path is unchanged.

Changes

stdio output

Layer / File(s) Summary
Git autocommit success message
packages/server/src/mcp/stdio.ts
The success message now uses console.error instead of console.log.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: madmoneymike5


Merge Risk: ⚪ Minimal · up to aeb9e

The Git autocommit confirmation now goes to stderr, leaving stdout available for MCP protocol traffic.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: keeping the Git autocommit notice out of stdout for the stdio transport.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thecodacus
thecodacus merged commit e752cee into main Oct 12, 2026
3 checks passed
@thecodacus
thecodacus deleted the fix/stdio-stdout-log branch October 12, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant