several improvements, fixes, ..#1
Open
Craeckie wants to merge 19 commits into
Open
Conversation
Use $MYSQL_USER and $MYSQL_PASS from link environment, if not passed as a local ENV (-e).
Wrapped the decision of using local v. link ENV and the set of the config in a function.
$MYSQL_ENV_MYSQL_PASSWORD seems to be used usually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only direction change is the use of sendmail, because it's very easy to set up.
The rest was getting rid of setup issues in phabricator.