Conversation
The AWSAnthropic count_tokens translator's ResponseError was a no-op, so Bedrock error bodies (e.g. a ValidationException when a model does not support CountTokens) were passed through to clients as-is instead of as an Anthropic error envelope. This mirrors the existing error handling in the Bedrock messages translator and reuses its status-to-error-type mapping by promoting it to a package-level helper. Signed-off-by: Kamil Dokumaci <dok@tuta.com>
✅ Deploy Preview for theagentrouter canceled.
|
missBerg
added
bug
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
AWSAnthropictranslator for/v1/messages/count_tokenshad a no-opResponseError, so when Bedrock rejects a request (for example aValidationExceptionbecause the model does not supportCountTokens) the client received Bedrock's raw error body instead of an Anthropic-style error envelope.This PR translates Bedrock error responses into
anthropicschema.ErrorResponse, mirroring what the Bedrock messages translator already does:awsbedrock.BedrockExceptionand the message is preserved.invalid_request_error,rate_limit_error, ...). The existing status-to-type mapping is promoted from a method on the messages translator to a package-level helper so both translators share it.Content-TypeandContent-Lengthheaders are set for the rewritten body.Example: a 400 from Bedrock with body
{"message": "The provided model doesn't support counting tokens"}now becomes{"type":"error","error":{"type":"invalid_request_error","message":"The provided model doesn't support counting tokens"},"request_id":""}Fixes #2546
Notes
make precommitandgo test ./internal/translator/...pass locally.