feat: support weekly, monthly, and yearly quota windows - #2662
Closed
fernandoescolar wants to merge 1 commit into
Closed
fernandoescolar wants to merge 1 commit into
fernandoescolar wants to merge 1 commit into
Conversation
✅ Deploy Preview for theagentrouter canceled.
|
Signed-off-by: Fernando Escolar <fernando.escolar@digits.schwarz>
fernandoescolar
force-pushed
the
main
branch
from
September 9, 2026 19:22
159721d to
0dfd66f
Compare
Author
|
Closing in favor of #2695, recreated from a dedicated branch (feat/quota-windows) instead of main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends QuotaPolicy duration support to include weekly, monthly, and yearly quota windows:
1wfor one week1mofor one month1yfor one yearThe Envoy Rate Limit Service API now exposes the corresponding WEEK, MONTH and YEAR rate limit units. This allows Agent Router users to configure longer-lived token quotas for weekly budgets, monthly spend limits, and yearly
quotas.
The CRD validation, generated Helm manifest, documentation, translator, and tests have been updated accordingly.
Related Issues/PRs
Related issue: [1]
Related PR: [2]
Special notes for reviewers
The Envoy Rate Limit Service API supports fixed units, not arbitrary duration multipliers. Its configuration uses requests_per_unit and a single rate limit unit, so formats such as
5d,30d, or365dcannot be represented directly.For that reason, this PR supports the native Envoy units
1w,1mo, and1yinstead of adding multiplier-based formats.These units represent Envoy rate-limit windows and are not calendar-aware billing periods.
1: #2469
2: envoyproxy/go-control-plane#1223