Skip to content

fix: propagate MCPRoute OAuth issuer to SecurityPolicy - #2645

Merged
nacx merged 8 commits into
theagentrouter:mainfrom
czczycz:fix/propagate-mcproute-oauth-issuer
Sep 15, 2026
Merged

nacx merged 8 commits into
theagentrouter:mainfrom
czczycz:fix/propagate-mcproute-oauth-issuer

Conversation

@czczycz

@czczycz czczycz commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Propagate MCPRoute.spec.securityPolicy.oauth.issuer to the generated SecurityPolicy JWT provider so Envoy Gateway validates the JWT iss claim.

Add regression assertions for explicit and auto-discovered JWKS configurations.

Related Issues/PRs (if applicable)

Fixes #2641

Special notes for reviewers (if applicable)

Tested with: go test ./internal/controller -run ^TestMCPRouteController_syncMCPRouteSecurityPolicy$ -count=1

Signed-off-by: zhenyangchao <zhenyangchao@gmail.com>
@czczycz
czczycz requested a review from a team as a code owner September 8, 2026 09:42
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.41%. Comparing base (9871ba7) to head (b6fe00f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2645      +/-   ##
==========================================
+ Coverage   86.40%   86.41%   +0.01%     
==========================================
  Files         185      185              
  Lines       24648    24649       +1     
==========================================
+ Hits        21297    21301       +4     
+ Misses       2167     2165       -2     
+ Partials     1184     1183       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@czczycz

czczycz commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@Hritik003 Hritik003 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can the CI be fixed?

@czczycz
czczycz requested a review from a team as a code owner September 10, 2026 02:42
@netlify

netlify Bot commented Sep 10, 2026

Copy link
Copy Markdown

Deploy Preview for theagentrouter canceled.

Name Link
🔨 Latest commit a2e5e9f
🔍 Latest deploy log https://app.netlify.com/projects/theagentrouter/deploys/6aa8d7bd68c0ea0008e837cb

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@czczycz

czczycz commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

lgtm, can the CI be fixed?

@Hritik003 Thanks for reviewing. All failed tests have been fixed.

@nacx
nacx enabled auto-merge (squash) September 14, 2026 13:25

@aish1331 aish1331 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking this up @czczycz!

@aish1331

Copy link
Copy Markdown
Contributor

/retest

@nacx
nacx merged commit ce8f806 into theagentrouter:main Sep 15, 2026
85 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCPRoute securityPolicy.oauth.issuer is not propagated to the generated SecurityPolicy JWT provider

7 participants