Conversation
Owner
Author
|
Comparison looks good for the 2018 Azerbaijan Race Comparison vs Pirelli
|
There was a problem hiding this comment.
Pull request overview
Fixes incorrect tyre stint/compound assignment in sessions where timing-app tyre messages are delayed at session start and arrive “bunched up” with identical timestamps, by introducing timestamp re-alignment logic and adding a regression test for the 2018 Azerbaijan GP case.
Changes:
- Adjusts how stint boundary timestamps are derived and passed into the tyre-info correction routine.
- Adds new logic to detect “bunched up” tyre messages at session start and rewrite their timestamps to align with stint brackets.
- Adds an integration-style test to ensure compounds are correctly assigned for a known affected session (GH#863).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
fastf1/core.py |
Updates stint split handling and adds session-start “bunched tyre data” timestamp correction within tyre-info fixing logic. |
fastf1/tests/test_input_data_handling.py |
Adds a regression test verifying compounds for ALO in 2018 Azerbaijan race are not missing a stint due to delayed tyre data. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
theOehrly
added a commit
that referenced
this pull request
Apr 29, 2026
(cherry picked from commit e4b795a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Detects when tyre data was delayed at the start of a session and all bunched up messages then have the same timestamp. In those cases, the timestamps are corrected so that they line up with their corresponding stints. This fixes issues with missing tyre data in some sessions.
Closes #863
ToDo
include proposed refactoring of tyre data parser from Fix silent dropping of stints in legacy list format (#863) #872implemented separately in MNT: refactor tyre data parsing for readability #903test against other sessions to ensure this breaks nothingassumptions made may only hold for race-like sessions: test and evaluateAI Disclosure
No AI tools used