Skip to content

dda: drop hardcoded scan 0..1000 in extract_precursor_ms1_signals #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theGreatHerrLebert merged 1 commit into from
May 20, 2026
Merged

dda: drop hardcoded scan 0..1000 in extract_precursor_ms1_signals #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rustdf/src/data/dda.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,9 +550,13 @@ impl TimsDatasetDDA {
let frame = &frames[idx];

// === XIC and Mobilogram: Extract from isotope range (or single m/z if no mono_mz) ===
// Scan range is unbounded; the inv_mobility window (im_min/im_max) does
// the mobility selection. A hardcoded scan cap (e.g. 0..1000) silently
// drops signal on methods configured with more than that many scans
// per frame (high mobility-resolution / wide IM range acquisitions).
let xic_filtered = frame.filter_ranged(
xic_mz_min, xic_mz_max,
0, 1000,
0, i32::MAX,
im_min, im_max,
0.0, 1e9,
0, i32::MAX,
Expand Down
Loading