Skip to content

buffering mod length #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the-thing merged 1 commit into from
Jul 25, 2026
Merged

buffering mod length #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions chipamp-player/src/main/java/com/github/thething/chipamp/mod/Sampler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ public final class Sampler {

private Mod mod;
private int sampleCount;
private long modLengthMicros;

private int sequenceIndex;
private int rowIndex;
private int tickIndex;
Expand Down Expand Up @@ -631,8 +633,7 @@ private void applyMidRowEffects() {
* @return the module's total playback duration in the requested unit
*/
public long getModLength(TimeUnit unit) {
long milliseconds = sampleCount * 1_000L / config.samplingRate * 1_000L;
return unit.convert(milliseconds, TimeUnit.MICROSECONDS);
return unit.convert(modLengthMicros, TimeUnit.MICROSECONDS);
}

/**
Expand Down Expand Up @@ -918,6 +919,7 @@ private void rebuildIndex() {
}

this.sampleCount = sampleCount;
this.modLengthMicros = sampleCount * 1_000L / config.samplingRate * 1_000L;
} finally {
config.loopDetectionEnabled = loopDetectionEnabled;
config.loggingEnabled = loggingEnabled;
Expand Down
Loading