Skip to content

fix: correct jira command for fetching issues - #442

Merged
tomdps merged 4 commits into
the-open-engine:mainfrom
jcarter:fix/correct-jira-command
Jul 29, 2026
Merged

fix: correct jira command for fetching issues#442
tomdps merged 4 commits into
the-open-engine:mainfrom
jcarter:fix/correct-jira-command

Conversation

@jcarter

@jcarter jcarter commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Summary

jira issue is not a valid command in the jira CLI.

Changes Made

Use correct command for fetching issues - jira view

Checklist

  • Tests pass (npm test)
  • Documentation updated (if needed)
  • Follows commit guidelines

@tomdps tomdps added the bug Something isn't working label Jul 29, 2026
@tomdps

tomdps commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Status review (2026-07-29):

  • Still relevant: current main’s src/issue-providers/jira-provider.js (JiraProvider.fetchIssue) still invokes jira issue view; go-jira’s command is jira view.
  • The one-line diff is compatible with the current callsite and fixes that command without changing parsing behavior.
  • Merge readiness: GitHub reports MERGEABLE but BEHIND, with no check runs or status contexts on the head; readiness is therefore not yet confirmed.

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown

Greptile Summary

Corrects Jira issue retrieval and adds regression coverage.

  • Replaces the invalid jira issue view invocation with jira view.
  • Adds a focused test verifying command construction, JSON parsing, normalized issue data, and module-cache cleanup.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/issue-providers/jira-provider.js Uses the supported go-jira view command while preserving JSON output and existing issue normalization.
tests/jira-provider.test.js Adds regression coverage for the corrected command and resulting normalized issue payload.

Reviews (4): Last reviewed commit: "Merge commit '6725252a9ca8a6062a86c74b1e..." | Re-trigger Greptile

@tomdps tomdps changed the title fix: Correct jira cli command for fetching issues fix: correct jira command for fetching issues Jul 29, 2026
@tomdps
tomdps force-pushed the fix/correct-jira-command branch from b162e70 to 0cc6cb0 Compare July 29, 2026 22:16
tomdps
tomdps previously approved these changes Jul 29, 2026

@tomdps tomdps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against current main and go-jira's top-level view command. Focused regression coverage proves the exact argv and parsed result; required checks are green.

@tomdps
tomdps added this pull request to the merge queue Jul 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 29, 2026

@tomdps tomdps left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed exact head 8dae60f after latest-main incorporation and the module-cache teardown correction. Product command, regression test, combined provider identity behavior, and required gates are green.

@tomdps
tomdps added this pull request to the merge queue Jul 29, 2026
Merged via the queue into the-open-engine:main with commit 3316742 Jul 29, 2026
10 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants