Try to reauthenticate on a http status code 403#59
Open
Conversation
quasipoint
requested changes
Feb 3, 2026
If we get a http status code 403, we should try to reauthenticate in case the session timed out. If we then still get the error, our user might miss the permissions for the requested action. Using a decorator to achieve this.
pnbecker
force-pushed
the
reauthenticate
branch
from
16843a2 to
427dd64
Compare
Member
Author
|
@quasipoint thank you. I like the idea with the decorator. I used it to refresh the csrf token and to handle the reauthenication. I have not tested this code yet. Could you please do a code review and if that looks better to you now, I will test the code. |
quasipoint
requested changes
Feb 4, 2026
dspace_rest_client/client.py
Outdated
| # as this method doesn't return the request, we cannot use our @reauthenticate decorator | ||
| # we should enhance self.api_post to be able to send files and use our decorators | ||
| if r.status_code == 401 and not reauthenticated: | ||
| self.reauthenticate |
There was a problem hiding this comment.
Should be self.authenticate()? This is a no-op as written
Member
Author
There was a problem hiding this comment.
good catch, fixed, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we get a http status code 403, we should try to reauthenticate in case the session timed out. If we then still get the error, our user might miss the permissions for the requested action.