Skip to content

Project finished!#725

Closed
Brandonscodedata wants to merge 3 commits into
the-csharp-academy:mainfrom
Brandonscodedata:main
Closed

Project finished!#725
Brandonscodedata wants to merge 3 commits into
the-csharp-academy:mainfrom
Brandonscodedata:main

Conversation

@Brandonscodedata

Copy link
Copy Markdown

I had so much fun! Please be brutal in your code review.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brandonscodedata Hi! Thanks for submitting your project.

At the moment, I’m unable to run or properly review the application because the submission appears to contain only Program.cs.

A console application can keep most of its logic in Program.cs, but the repository still needs to contain the complete project structure, including the .csproj file and every class referenced by the code.

Once the full project is available and builds successfully, it can be reviewed against the project requirements.

Could you please fix so we can proceed?

@Brandonscodedata

Copy link
Copy Markdown
Author

@TheCSharpAcademy Hi, I have pushed the missing project files now. Could you please review again?

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brandonscodedata Thanks for resubmitting. At the moment the code doesn't compile, could you please check? You can click on the "files changed" tab to see what was submitted: https://github.com/the-csharp-academy/CodeReviews.Console.MathGame/pull/725/changes

Image

@Brandonscodedata

Copy link
Copy Markdown
Author

@TheCSharpAcademy Hi again! I have finally pushed the correct files and fixed the build issues. I'm still quite new to GitHub, so I sincerely apologize for the back-and-forth and the extra hassle! I hope I'll get it right much faster next time. Could you please review the project again? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants