Ready for review#18
Open
Solomonlol wants to merge 10 commits into
Open
Conversation
TheCSharpAcademy
requested changes
Jul 23, 2026
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@Solomonlol Thanks for submitting, there's an issue with the way you're saving dates. Because I'm in Australia I'm getting this error:
Dates are saved using:
date.ToString()
That output depends on the computer’s current culture. When records are read, the application expects one exact format:
DateTime.ParseExact(
reader.GetString(3),
"dd.MM.yyyy H:mm:ss",
CultureInfo.InvariantCulture)
These formats are not guaranteed to match. For example, a machine using an English-US culture may save a value containing slashes and AM/PM, which would then cause ParseExact to throw when the records are displayed.
Store and read the date using the same explicit format.
Let me know
Author
|
I assume the problem has been resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.