Skip to content

fix(menubar): address review feedback for #889 - #892

Merged
diazdesandi merged 1 commit into
thaw-app:fix/menubar-reliabilityfrom
VailElla:codex/pr-889-review-fixes
Aug 5, 2026
Merged

fix(menubar): address review feedback for #889#892
diazdesandi merged 1 commit into
thaw-app:fix/menubar-reliabilityfrom
VailElla:codex/pr-889-review-fixes

Conversation

@VailElla

@VailElla VailElla commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Addresses all seven unresolved review findings on #889 without expanding the parent PR behavior:

  • keep gesture drag coordinates consistent and move the landing query outside the event semaphore;
  • reclassify sections after every H_ctrl attempt before AH_ctrl and fallback planning;
  • remove remaining retired-setting references and fix the two review-found test issues.

Parent PR

This is a stacked PR targeting fix/menubar-reliability. Merge this first, or cherry-pick commit 730e1715, so #889 receives the fixes without unrelated history.

Closes: N/A

Validation

  • Xcode 27 Beta 4: 1961 tests in 253 suites passed on exact commit 730e1715
  • focused regression: 35 tests in 6 suites passed
  • swift build --package-path ThawCtl
  • Swift parse, SwiftFormat on the changed non-core files, and git diff --check
  • DCO sign-off and GitHub noreply identity verified

Risk and rollback

No persisted-data migration or default-setting change. The gesture option remains off by default. Roll back by reverting 730e1715.

Signed-off-by: VailElla <63608800+VailElla@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 54f7ac94-5f61-44a0-a049-ab60ef631c24

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the menubar Hide/show, sections, control items, backends, capacity label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Labels: menubar

All convention checks passed. ✅

cc @VailElla

@VailElla VailElla closed this Aug 5, 2026
@VailElla VailElla reopened this Aug 5, 2026

@diazdesandi diazdesandi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diazdesandi
diazdesandi merged commit fa965b6 into thaw-app:fix/menubar-reliability Aug 5, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

menubar Hide/show, sections, control items, backends, capacity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants