Skip to content

chore(refactor): decoupled oxlint and eslint - #38

Merged
thatonevikash merged 2 commits into
mainfrom
chore/decouple-eslint-and-oxlint
Aug 28, 2026
Merged

thatonevikash merged 2 commits into
mainfrom
chore/decouple-eslint-and-oxlint

Conversation

@thatonevikash

@thatonevikash thatonevikash commented Aug 28, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Added linter selection during project setup, with Oxlint recommended by default.
    • Added support for choosing ESLint or no linter.
    • The --yes option now automatically selects Oxlint.
    • Added Oxlint and ESLint as available features for the add command.
  • Updates

    • New ESLint configuration is available when ESLint is selected.
    • Simplified default templates by removing built-in linting configuration and scripts.

@thatonevikash thatonevikash linked an issue Aug 28, 2026 that may be closed by this pull request
@vercel

vercel Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
create-next-mui Ready Ready Preview Aug 28, 2026 5:43pm

@coderabbitai

coderabbitai Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

Next included review available in 55 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 316ef179-38c6-46bb-8d99-8bf3a455fc0f

📥 Commits

Reviewing files that changed from the base of the PR and between daed6e3 and 6f635f6.

📒 Files selected for processing (1)
  • .github/workflows/testing.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 324df0cf-e3e1-4fda-8608-19ecd769d9be

📥 Commits

Reviewing files that changed from the base of the PR and between 0fbba28 and daed6e3.

📒 Files selected for processing (9)
  • next-mui-features/eslint/manifest.json
  • next-mui-features/eslint/source/eslint.config.mjs
  • next-mui-features/oxlint/manifest.json
  • next-mui-features/oxlint/source/.oxlintrc.json
  • next-mui-features/oxlint/source/eslint.config.mjs
  • next-mui-templates/base-js/eslint.config.mjs
  • next-mui-templates/base-js/package.json
  • next-mui-templates/base-ts/package.json
  • src/index.js
💤 Files with no reviewable changes (2)
  • next-mui-templates/base-js/eslint.config.mjs
  • next-mui-features/oxlint/source/eslint.config.mjs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The CLI now supports Oxlint, ESLint, and no-linter selections. ESLint has a dedicated feature package. Oxlint no longer invokes ESLint. Base templates no longer include built-in ESLint configuration.

Changes

Linter feature packaging and template cleanup

Layer / File(s) Summary
Linter feature packages
next-mui-features/eslint/*, next-mui-features/oxlint/*, next-mui-templates/base-js/package.json, next-mui-templates/base-ts/package.json
Adds the ESLint flat config and package manifest. Updates Oxlint scripts and rules. Removes ESLint scripts and dependencies from both base templates.

CLI linter selection and application

Layer / File(s) Summary
CLI linter selection and scaffolding
src/index.js
Adds linter choices, defaults --yes to Oxlint, accepts Oxlint and ESLint in add, displays the selection, and applies the selected feature before optional features.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to daed6

The PR separates linter configuration into selectable ESLint, Oxlint, or no-linter features without a supported merge-blocking impact; no actionable risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant CLI
  participant LinterFeature
  participant OptionalFeatures
  User->>CLI: Select Oxlint, ESLint, or none
  CLI->>CLI: Display linter selection
  CLI->>LinterFeature: Apply selected linter feature
  CLI->>OptionalFeatures: Apply optional features
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: separating Oxlint and ESLint configurations and selection in the CLI.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (5 skipped: 5 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/decouple-eslint-and-oxlint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thatonevikash
thatonevikash merged commit aebcec5 into main Aug 28, 2026
6 checks passed
@thatonevikash
thatonevikash deleted the chore/decouple-eslint-and-oxlint branch August 28, 2026 17:44

This branch was successfully deployed

1 active deployment
Preview — 6f635f6a Deployed Aug 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decouple oxlint & eslint, make both standalone as features

1 participant