This repository was archived by the owner on Jan 8, 2025. It is now read-only.
Load all files in a data directory: "_all.yml" and other files if present#89
Merged
Merged
Conversation
Collaborator
Author
|
I'm happy to tidy, add tests, etc. |
Owner
|
Sounds like a great idea 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of 6e5dc92 from #67 .
I've tested it, and it works.
I can see some benefit in this, e.g. allowing _all.yml to contain vetted stable entries, or an archive, while new data files are created for new items, which might be migrated to _all.yml at a later date.
A database constraint occurs if the _all.yml and an individual data file contain the same key, which is appropriate. A follow up task can improve that to provide a better contextual message.