Skip to content

chore[notask]: align speech, translation and diffusion addons - #3900

Closed
donriddo wants to merge 1 commit into
mainfrom
feat/sdk-align-native-addon-versions
Closed

chore[notask]: align speech, translation and diffusion addons#3900
donriddo wants to merge 1 commit into
mainfrom
feat/sdk-align-native-addon-versions

Conversation

@donriddo

@donriddo donriddo commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

#3902 aligned the llama-family addons on the fabric-10069 backend set and #3857 brought tts-ggml up. The remaining bundled addons (bci-whispercpp, audiogen-ggml, diffusion-cpp) are still on older fabric / addon-cpp builds, so on mobile the flattened native lib dir keeps a mixed backend set — the iOS JsAsyncTask crash blocking the integration PRs (e.g. #3682): the app loads the LLM, then dies loading the embedding model.

📝 How does it solve it?

Bumps the still-behind addons to their fabric-aligned releases:

Package From To
@qvac/bci-whispercpp 0.6.0 0.7.1
@qvac/audiogen-ggml 0.1.0 0.2.2
@qvac/diffusion-cpp 0.17.0 0.20.0

It also floors @qvac/tts-ggml at 0.7.2 (was ^0.7.0), the registry-client@^0.6.1 line, so the hyperdb dedup fix is guaranteed rather than resolved by chance.

Each was checked against actual SDK usage, not just types: none introduce an SDK-facing API break. The tts pace narrowing already landed on main via #3857, so this PR is purely the version bumps.

🧪 How was it tested?

Typecheck clean; test-e2e-full run for the mobile lanes to confirm the app survives the LLM → embedding transition that crashes today.

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

License compliance — findings detected (warn-only)

Critical: 0 · High: 4 · Medium: 0

Dependency License Scope Severity Outcome
@qvac/audiogen-ggml@^0.2.2 (none detected) runtime High blocks
@qvac/bci-whispercpp@^0.7.1 (none detected) runtime High blocks
@qvac/diffusion-cpp@^0.20.0 (none detected) runtime High blocks
@qvac/tts-ggml@^0.7.2 (none detected) runtime High blocks

How to resolve a blocking finding:

  • Remove or replace the disallowed dependency, or
  • If the license is genuinely acceptable, run the compliance SKILL and record the decision in .github/license-allowlist.yml (CODEOWNERS-reviewed), or
  • For a one-off, a maintainer can apply the license-override label (High findings only; Critical cannot be overridden).

Warn-only (shadow) mode — this check does not block merges yet.

Updated automatically by the canonical license compliance workflow.

NOTICE presence (advisory)

Missing NOTICE (advisory, does not block):

  • ./.github/actions/release-merge-guard
  • ./docs/website
  • ./packages/ggml-coload-smoke
  • ./packages/fabric/test/integration
  • ./packages/inference-addon-cpp/mobile
  • ./packages/sdk/e2e
  • ./packages/llm-llamacpp/benchmarks/performance
  • ./packages/llm-llamacpp/benchmarks/server
  • ./packages/vla-ggml/sim/server
  • ./packages/embed-llamacpp/benchmarks/performance
  • ./packages/embed-llamacpp/benchmarks/server
  • ./packages/asr-ggml/benchmarks/server

@donriddo donriddo added the test-e2e-full Triggers full e2e test suite [Currently SDK-only] label Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ❌ PENDING
Approvals so far: none

Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member.

@donriddo
donriddo marked this pull request as ready for review August 17, 2026 12:55
@donriddo
donriddo requested review from a team as code owners August 17, 2026 12:55
@donriddo donriddo added test-e2e-full Triggers full e2e test suite [Currently SDK-only] and removed test-e2e-full Triggers full e2e test suite [Currently SDK-only] labels Aug 17, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@donriddo donriddo added test-e2e-full Triggers full e2e test suite [Currently SDK-only] and removed test-e2e-full Triggers full e2e test suite [Currently SDK-only] labels Aug 17, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment thread packages/sdk/package.json
@donriddo donriddo closed this Aug 17, 2026
@donriddo donriddo reopened this Aug 17, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

GustavoA1604
GustavoA1604 previously approved these changes Aug 18, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Raise the remaining bundled addons to their fabric-aligned releases so the
native bundle links one backend set: bci-whispercpp 0.7.1, audiogen-ggml 0.2.2,
diffusion-cpp 0.20.0, and tts-ggml floored at 0.7.2 (the registry-client 0.6.1
line that resolves the hyperdb dedup). The llama-family, translation-nmtcpp,
and the tts pace / contract / Python-client changes are already on main.
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — ios — ❌ failed

Totals: 227/491 passed · 185 failed · 55.1% · 2020s
Config: suite=(none) · filter=(none) · exclude=(none)
Device pool: iPhone 16 Pro - iOS 26 — ☀️ highly available
View run · Artifacts: reports · Device Farm logs

Results by section

  • addon-logging: 0/11 ❌
  • audiogen: 0/3 ❌
  • cancellation: 0/6 ❌
  • classification: 0/4 ❌
  • completion: 43/46 ❌
  • config: 0/2 ❌
  • config-reload: 0/6 ❌
  • delegated-inference: 0/13 ❌
  • diffusion: 0/23 ❌
  • download: 0/5 ❌
  • finetune: 0/7 ❌
  • lifecycle: 0/12 ❌
  • logging: 0/9 ❌
  • model: 7/13 ❌
  • multi-gpu: 0/2 ❌
  • plugin: 0/6 ❌
  • registry: 0/11 ❌
  • snap: 0/1 ❌
  • system-resources: 0/3 ❌
  • tts: 0/26 ❌
  • vision: 0/14 ❌
  • vla: 0/12 ❌
  • wrong-model: 0/1 ❌

Failed tests

  • 184 tests: Consumer died before test could be executed
    Affected: classification-confidence-sum, classification-topk, classification-invalid-image, tts-chatterbox-short-text, tts-chatterbox-medium-text, and 179 more
  • classification-results-shape: Consumer became unresponsive (no heartbeat for 126s)

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — android — ❌ failed

Totals: 367/491 passed · 2 failed · 99.5% · 5499s
Config: suite=(none) · filter=(none) · exclude=(none)
Device pool: Google Pixel 10 Pro - Android 16 — ☀️ highly available
View run · Artifacts: reports · Device Farm logs

Results by section

  • tts: 24/26 ❌

Failed tests

  • tts-cosyvoice3-emotion-conditioning: Test timeout after 360s
  • tts-cosyvoice3-native-streaming: Test timeout after 180s

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — windows — ❌ failed

Totals: 487/491 passed · 1 failed · 99.8% · 2211s
Config: suite=(none) · filter=(none) · exclude=(none)
View run · Artifacts: reports

Results by section

  • logging: 8/9 ❌

Failed tests

  • logging-timestamp-accuracy: Need >= 2 logs to verify timestamps, got 1

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — linux — ✅ all tests passed (488/491, 1515s)

Config: suite=(none) · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — macos — ✅ all tests passed (488/491, 1009s)

Config: suite=(none) · filter=(none) · exclude=(none)
View run · Artifacts: reports

@donriddo

Copy link
Copy Markdown
Contributor Author

Closing as redundant: the addon alignment bumps have been folded into #3682 (the multi-job PR) per the team decision, so #3682 now carries the multi-job feature plus the full aligned bundle (bci 0.7.1, audiogen 0.2.2, diffusion 0.20.0, tts 0.7.2, and the llama-family/tts-pace from main). No need for a separate alignment PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-e2e-full Triggers full e2e test suite [Currently SDK-only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants