tests: derive expected file list from templates/; README: dogfooding note - #2
Merged
Conversation
…ding Code-review pass on the bootstrapped repo: - tests/install.bats derived the expected file set and the byte-identical checks from a hardcoded 6-file list, which silently contradicted the installer's headline property (copy list derived from templates/, add a file and it ships automatically). Replace both with a `template_dest` helper + `find templates/` derivation, so dropping a template in is covered end-to-end with nothing to hand-maintain. Verified: a new template is auto-covered, and the byte-identical check still goes red on a mismatch. - README: add a one-line "dogfooded" note now that the repo runs its own kit. No changes to install.sh behavior. shellcheck clean, bats 10/10. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Post-bootstrap code-review pass on the repo. Two focused changes:
tests/install.bats— derive the expected file list fromtemplates/.The suite hardcoded a 6-file list (in
expected_files()and six explicitdiffs), which quietly contradicted the installer's headline property: the copy list is derived fromtemplates/— drop a file in and it ships automatically, nothing to keep in sync. A new template would have been installed but covered by no test. Replaced both with atemplate_desthelper +find templates/derivation, mirroring the installer'sadapters/-stripping rule.README.md— one-line "dogfooded" note, now that the repo runs on its own kit.No change to
install.shbehavior.Verification
shellcheck install.sh→ cleanbats tests/install.bats→ 10/10adapters/.aider/CONVENTIONS.md) is auto-installed and auto-verified with zero test edits.🤖 Generated with Claude Code